Eliminate evm::buffer::Inner::Empty
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Empty` variant was added when we had different memory allocators. Currently we can also represent the emptyness of the buffer trough the `Inner::Owned` variant since that holds a `Vec` which can be empty. This commit replaces `Inner::Empty` with `Inner::Owned(Vec::default())`.
mickvangelderen
commented
Jan 12, 2024
anton-lisanin
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Emptyvariant was added when we had different memory allocators. Currently we can also represent the emptyness of the buffer trough theInner::Ownedvariant since that holds aVecwhich can be empty.This commit replaces
Inner::EmptywithInner::Owned(Vec::default()).This change makes it so that future readers of the code do not need to worry about how
Inner::Emptyis different fromInner::Owned(Vec::default), and whatEmptythen represents exactly. This change is a pre-refactor required to improve howBufferis used in the rest of the code base.