Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak: Activity Leak on PixlUIfaceManager.INSTANCE #31

Closed
jackcsk opened this issue Jul 21, 2017 · 1 comment
Closed

Memory Leak: Activity Leak on PixlUIfaceManager.INSTANCE #31

jackcsk opened this issue Jul 21, 2017 · 1 comment

Comments

@jackcsk
Copy link

jackcsk commented Jul 21, 2017

PixlUIfaceManager.INSTANCE holds reference of the first activity using the widgets, and causing memory leak. (Activity is not released properly)

There are 2 options to address this issue:

  • Call PixlUIfaceManager.getInstance(applicationContext) in Application class, or
  • modify the class to reference to application context.

Which one would you prefer?

@neopixl
Copy link
Collaborator

neopixl commented Jul 21, 2017

Thanks @jackcsk.

We will reference the application context in PixlUIfaceManager (second option).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant