Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language select #38

Closed
xeonkeeper opened this issue Oct 16, 2018 · 3 comments
Closed

Language select #38

xeonkeeper opened this issue Oct 16, 2018 · 3 comments

Comments

@xeonkeeper
Copy link

Can you improve the feature to change default language and titles without project build in VS? It's may be separate XML files and etc? I want to translate to cyrilic.
Other things work great for now.

@redhook62
Copy link
Member

@xeonkeeper

I understand your request, but as you may suspect, we do not have the ability to translate the user interface into any language as Microsoft can.
It is above all, to respect the practices set up in ADFS. This is why translations are compiled into satellite assemblies. The language of the user is displayed by default in ADFS, however, at the moment we only support English, French and Spanish (google translate).
So, if you want to have a cyrilic translation, you can perform the translation on .resx files (resources), and transmit them in pull request. We will be happy to integrate them as soon as possible and to follow with you the evolutions

Best regards

@xeonkeeper
Copy link
Author

xeonkeeper commented Oct 17, 2018

Ok, i to be translating .resx to rus soon) But, i'm mean other. A lot of people using english backend, not need to be translating it. But front end, for usual employees, need to be translating to native language simply, without build project in VS. The same way, administartors can wont to change some titles.
Logically, it is good to make these settings in external files like C: \Program Files\MFA\ languages \rus\languagerus.xml

@redhook62
Copy link
Member

Ok, I understand your position.
It's also a question of security, no external code !

Also a lot of people taking this component do it with good reason or because they do not trust Microsoft's MFA (look at the Azure Provider code) or have to pay for it.

We also want this component to become "industrial as possible" that can be deployed in an ADFS server farm without worries.

You can only translate the UI Web parts and omit the console and the powershell if you wish.
By integrating your language, it may be that others will be very happy to benefit from your participation.

moreover the source code is available and modifiable according to your wishes, we made the effort to package all, that is not really common on GitHub where we mostly share code.

If you post the resx, we will integrate them immediately.

Thanks
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants