Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dev experience on windows #3111

Open
mhsdesign opened this issue Jul 15, 2023 · 0 comments
Open

Improve Dev experience on windows #3111

mhsdesign opened this issue Jul 15, 2023 · 0 comments

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Jul 15, 2023

also the phpBinaryPathAndFilename always needs to be configured automatically.

By default (xampp) PHP_BINDIR will be C:\php which is totally wrong in my installation (should be some local directory inside xampp)

but PHP_BINARY contains the correct path, so im wondering if we should use it on windows instead, so one can at least compile flow via subprocess, and start the inbuilt server?

# Path and filename of the PHP binary
# The constant PHP_BINDIR usually contains the path, but on Windows this doesn't work reliably
phpBinaryPathAndFilename: '%PHP_BINDIR%/php'

edit: i think phpPathAndBinary should default to %PHP_BINARY% on windows in case %PHP_BINDIR%/php is invalid so that at least flow server run and flow configuration show works.

this can be realized when declaring flows environment variables. Wed need: FLOW_PHP_BINARY which can then be referenced in the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant