What I did Extended the array that is used in the view. So that we have the provider identifier and the label. So we use a structure like
[ { identifier: 'Neos.Neos:Backend' label: 'Neos Backend label' }, { identifier: 'Neos.Neos:FooName' label: 'Neos Backend Foo' } ]
How to verify it
- Configure a second authentication provider
- go to the user management in the backend
- create a new user
- check the drop down
!Screenshot 2021-11-03 at 10 27 50
- Fixes: #3488
- Packages:
BrowserNeos
Adjusts the DefaultPropertyEditorPostprocessor such that it respects the configured property editor defaults not only for node _properties but for _creationDialog elements too.
This also fixes the default behavior for properties slightly by making sure that editor defaults from Neos.Neos.userInterface.inspector.editors are applied even if no corresponding Neos.Neos.userInterface.inspector.dataTypes exists
- Fixes: #3471
- Packages:
BrowserNeos
This wraps the property mapper exceptions within Node::getProperty() in order to throw a more useful exception.
- Fixes: #3420
- Packages:
BrowserNeos
When you delete an electronic address we throw a flash message that the address has been delete for the given user. We had the issue that the PersonName object could not be transformed to a string that is needed for the flash message.
What I did
Use the full name of the PersonName object instead of the direct PersonName object for the flash message.
How to verify it
- Open the user module
- Edit a user
- Optionally create a electronic address
- Delete a electronic address
- check the flash message
- Fixes: #3435
- Packages:
BrowserNeos
Fixes a duplicate id and the use of literal HTML tags in XLIFF.
- Packages:
MediaNeos
This pull request applies code style fixes from an analysis carried out by StyleCI.
---
For more information, click here.
- Packages:
ContentRepositoryFusionMediaNeos
This pull request applies code style fixes from an analysis carried out by StyleCI.
---
For more information, click here.
- Packages:
ContentRepositoryFusion
Since Neos 5.2.0 the use of frontend logins is broken. When logging in, an exception is thrown. The exact exception varies, but can be traced to Unexpected user type "". An account with the identifier "…" exists, but the corresponding party is not a Neos User. eventually.
This change fixes that by not using getUser() directly, but doing more checks and eventually just returning null if no Neos user can be found for the authenticated tokens.
This pull request applies code style fixes from an analysis carried out by StyleCI.
---
For more information, click here.
- Packages:
ContentRepositoryFusionMediaNeos
This pull request applies code style fixes from an analysis carried out by StyleCI.
---
For more information, click here.
- Packages:
ContentRepositoryFusionMediaNeos
This pull request applies code style fixes from an analysis carried out by StyleCI.
---
For more information, click here.
- Packages:
Neos
Aligns the file with the one in the Flow development collection.
This extends \Neos\Neos\Fusion\Cache\ContentCacheFlusher::registerChangeOnNodeIdentifier() such that it flushes dynamic node tags, too.
Background:
The Neos.Neos:ConvertUris processor invokes \Neos\Fusion\Core\Runtime::addCacheTag() for every converted node and asset link leading to a cache tag of <type>DynamicTag_<id> (e.g. NodeDynamicTag_12345) to be added to the current RuntimeContentCache.
This fix makes sure that those dynamic node tags are also flushed whenever a node is changed.
- Fixes: #3482
- Packages:
Neos
What I did To make the tag name visible when hovering an active tag /collection/asset source I changed the background color to blue.
How I did it On hover the background color of a button changes to blue while the font color changes to white
How to verify it In the media browser, if you have a lot of tags(more than 25 Tags), the collections and tags are displayed as 'buttons'. On hovering an active button, the text is white on blue.
- Resolves: #3461
- Packages:
Browser
The removal of all whitespaces connected to newlines yields unexpected results in text literals. This change adjusts the behavior and converts newlines and connected whitespaces inside of text literals to a single space. Whitespaces and connected newlines at the beginning and end of text literals are still removed.
So the following afx code: ` <h1> This is a string literal with multiple lines that shall collapse to spaces. </h1> will be transpiled as: Neos.Fusion:Tag { tagName = 'h1' content = 'This is a string literal with multiple lines that shall collapse to spaces.' } instead of: Neos.Fusion:Tag { tagName = 'h1' content = 'This is a string literalwith multiple linesthat shall collapseto spaces.' } * Relates: #3331 <#3331>_ * Packages: Afx github`
4 spaces is what Composer uses itself…
What I did / How I did it
I altered the NodeTypeConfigurationEnrichmentAspect so that it takes the node type inheritance chain into account when translating select box option labels in the respective inspector editor configuration.
This addresses an issue originally reported in the UI repo: neos/neos-ui#2005
How to verify it
You'll need a mixin NodeType that provides a select box property with internationalized option labels like this:
`yaml brandColor: type: string defaultValue: 'primary' ui: label: i18n reloadIfChanged: true inspector: group: style position: 10 editor: 'Neos.Neos/Inspector/Editors/SelectBoxEditor' editorOptions: values: 'primary': label: i18n 'turquoise': label: i18n 'gray-dark': label: i18n 'gray-light': label: i18n 'toyota-red': label: i18n 'yellow': label: i18n (let's call this one `Vendor.Site:Mixin.BrandColor)
Then you'll need a second node type that inherits from Vendor.Site:Mixin.BrandColor and adds an new internationalized option to the property `brandColor`:
`yaml brandColor: defaultValue: 'none' ui: inspector: editorOptions: values: 'none': label: 'i18n'`
Before the fix the new option will show up as a plain string "i18n". After the fix the new option will show up as an XLIFF-translation address (bound to the node type that added the option).
Additional remarks
Imho, the entire NodeTypeConfigurationEnrichmentAspect should actually be moved out of the Neos.Neos package and into the UI package (All of these translations are an exclusive UI concern). Doing that would be out-of-scope for a bugfix though.
- To be precise: There are no tests for this aspect to begin with and would be extremely difficult to add them. I'd suggest to move this concern over to the UI and handle it in a more testable manner.
- [x] The PR is created against the lowest maintained branch
- Packages:
Neos
When using the ContentCollectionRenderer directly and setting the backwards compatible collection prop (to still support Neos 4.3) to a valid array of nodes the following error appears due to the missing object definition:
` No Fusion object found in path ".../collectionA<Neos.Neos:ContentCollectionRenderer>/items/__meta/process/collectionLegacy`
What I did
Define the backwards compatible process as simple expression instead of an object without implementation
How to verify it
Try the following code somewhere in the demo site:
` myCollection = Neos.Neos:ContentCollectionRenderer { collection = ${q(site).find('[instanceof Neos.Demo:Content.Text]').get()} }`
- Packages:
Neos
What I did 1. Go to the Neos Media Browser and enter a search term 2. Remove the search term so that there is an empty string as search 3. Search again 4. Use any tag on the left side to search by tag
After clicking on the Tag I would expect to see results by tag since the search field is empty. The search still tries search by the empty string and does not call the method findByTag.
How I did it In the controller where the search happens do not only check if the searchterm is null but also check if the searchterm is empty
How to verify it After searching by searchterm, then searching by an empty string you can then search by Tag.
- Fixes: #3455
- Packages:
Browser
The command FLOW_CONTEXT=Testing/Behat ./flow behat:setup && ./flow doctrine:create && ./flow doctrine:migrationversion --add --version all is broken, because the context is only active for the behat:setup call, not the doctrine:… calls later.
- Packages:
github
This pull request applies code style fixes from an analysis carried out by StyleCI.
---
For more information, click here.
- Packages:
ContentRepositoryFusion
This pull request applies code style fixes from an analysis carried out by StyleCI.
---
For more information, click here.
- Packages:
ContentRepositoryFusion
The BackendControllerSecurityTest did not assert the login actually works in the test indexActionIsGrantedForAdministrator().
- Packages:
Neos
The icons are always white and when the asset source is active and on a small viewport we switch the background also to white. So the icons are not visible anymore.
This patch will adjust the color of the icon via filter functions. As we are not able to use the fill rule.
- Fixes: #3417
What I did We now use the css filter to modify the color of the icons. ` filter: invert(.5) sepia(1) saturate(5) hue-rotate(175deg);`
How to verify it
- Install a second asset source and go to the media module.
- Shrink the viewport to less than 767 pixels width
- Check if the icon of the active asset source is visible
media-assetsource.mp4
- Packages:
Browser
Show hotel icon instead of bed
- Relates: #2697
- Packages:
Neos