node:repair removeDisallowedChildNodes removes allowed nodes

[kdambekalns]

Description

When variants of a node differ in type, and thus some variants allow children while other don't allow them, allowed nodes will be removed.

Steps to Reproduce

1. Have variants of the same node, one being a document (with a "main" content collection) and one being a shortcut
2. Call ./flow node:repair --only removeDisallowedChildNodes

Expected behavior

Existing disallowed children of the shortcut are removed, other's left in place

Actual behavior

Even the children of the document nodes are removed

Affected Versions

Neos: probably all supported versions…

[kdambekalns]

As far as I can tell, the cause is that removeDisallowedChildNodes calls removeNodeAndChildNodesInWorkspaceByPath - and that will remove all the nodes, since they have the same path. The (potentially differing) type is no longer taken into account…