Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thumbnailCreated signal is emitted even if thumbnail creation failed #3573

Closed
kdambekalns opened this issue Jan 18, 2022 · 0 comments
Closed

Comments

@kdambekalns
Copy link
Member

Description

see

$thumbnail = new Thumbnail($asset, $configuration);
$this->emitThumbnailCreated($thumbnail);
// If the thumbnail strategy failed to generate a valid thumbnail
if ($async === false && $thumbnail->getResource() === null && $thumbnail->getStaticResource() === null) {
$this->thumbnailRepository->remove($thumbnail);
return null;
}

Expected behavior

Signal is emitted after successful thumbnail creation

Actual behavior

Signal is emitted unconditionally

Affected Versions

Neos: 5.3+

@kdambekalns kdambekalns changed the title emitThumbnailCreated is emitted even if thumbnail creation failed thumbnailCreated signal is emitted even if thumbnail creation failed Jan 18, 2022
@kdambekalns kdambekalns self-assigned this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants