Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Use local fonts instead of from Google #3873

Closed
wants to merge 1 commit into from

Conversation

kdambekalns
Copy link
Member

@kdambekalns kdambekalns commented Aug 30, 2022

Removes the use of remote fonts from Google in favor of local
font files.

Review instructions

Noto should still be the font used on error pages.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kdambekalns kdambekalns self-assigned this Aug 30, 2022
@kdambekalns
Copy link
Member Author

Note: I did not test this, just hacked it in the GitHub browser UI after looking at the code. 😎

@markusguenther
Copy link
Member

Hmm we need to build the pipeline as well...
No time now but will keep it in mind.

@Sebobo
Copy link
Member

Sebobo commented Oct 11, 2022

Closing this in favour of #3919

@Sebobo Sebobo closed this Oct 11, 2022
@kdambekalns kdambekalns deleted the task/use-local-fonts branch October 11, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants