Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0: Rebuild editPreviewModes #3984

Closed
mhsdesign opened this issue Dec 20, 2022 · 1 comment
Closed

9.0: Rebuild editPreviewModes #3984

mhsdesign opened this issue Dec 20, 2022 · 1 comment
Assignees
Labels

Comments

@mhsdesign
Copy link
Member

WIP writeup ...

currently the editPreviewMode is available via:
node.context.currentRenderingMode -> UserInterfaceMode

and it will be added to the GlobalCacheIdentifiers

editPreviewMode = ${documentNode.context.currentRenderingMode.name}

The neos ui allows to change the preview modes, but this change affects the whole session.


This has now been temporarily removed with the new CR, as context is dumped, and the nodeInfo helper (a replacement for node.inBackend https://github.com/neos/neos-ui/blob/f501f800f28c3523a90d52f807148cddf54ebb79/Classes/Fusion/Helper/NodeInfoHelper.php#L530) doesnt know anything about the preview mode too.

We should consider passing the currentRenderingMode via request parameter.
Question is, how we handle caching and allow uncached segments to work.

(fx. opening the preview in the iframe should not have the node uris converted, but when using the preview button (effectively the same route) the uris should function normally and be converted)

Im hoping to also fix these bugs in the same run:

@mhsdesign mhsdesign added the 9.0 label Dec 20, 2022
@mhsdesign mhsdesign self-assigned this Jun 23, 2023
@mhsdesign mhsdesign linked a pull request Jul 10, 2023 that will close this issue
9 tasks
@mhsdesign
Copy link
Member Author

Close as dub of #4086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant