Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: nodetypes:// normalize the path to unix #4374

Closed
wants to merge 1 commit into from

Conversation

mhsdesign
Copy link
Member

as nodetypes://Foo.Bar\SomeFile.bar might be requested on windows, and we split later on unix slash /

resolves: #4358 in combination with #4359

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

as `nodetypes://Foo.Bar\SomeFile.bar` might be requested on windows, and we split later on unix slash `/`

resolves: #4358
@dlubitz
Copy link
Contributor

dlubitz commented Jun 29, 2023

I don't get, why you should fix a wrong "nodetype://" path here. Shouldn't we fix where that got wrongly built?

@mhsdesign
Copy link
Member Author

The RecursiveIteratorIterator in the FilePatternResolver builds them invalid / in windows style

@mhsdesign
Copy link
Member Author

but thx @dlubitz for setting the bar high ;) I just found FilesystemIterator::UNIX_PATHS which might do as well. And even better ^^

@mhsdesign
Copy link
Member Author

Yes the flag works as expected ;)

@dlubitz what do you say - should we also use the flag here neos/flow-development-collection#3088?

@mhsdesign mhsdesign closed this Jun 30, 2023
@mhsdesign mhsdesign deleted the bugfix/4358-nodetypes-streamwrapper-windows branch June 30, 2023 07:52
@dlubitz
Copy link
Contributor

dlubitz commented Jun 30, 2023

I'm not that deep in this, but this is a different thing, isn't it?
In findComposerPackagesInPath you need the windows-formated path for iterating the recursive (L636) and just the return of findComposerPackagesInPath would be in Unix-style. Writing that raises the question... WHY?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants