Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: ContentCache entries and keys are not workspace/contentstream aware #4810

Open
dlubitz opened this issue Dec 18, 2023 · 3 comments
Open
Assignees
Labels
Milestone

Comments

@dlubitz
Copy link
Contributor

dlubitz commented Dec 18, 2023

In Neos <9.0 we stored the workspace name of a node, within the content cache key to be able to flush caches more precisely and prevent exposing cached user-workspace content to live.

We need to discuss, what fits best here: workspace name or contentstream id
And add the addional identifier to the cache keys in cache creation and flushing.

We also should check if it's still needed to iterate over workspace hirarchy for cache flushing, as we do it in Neos <9.0.

@mhsdesign
Copy link
Member

As discussed in #4940 (comment)

requiring the contentStreamId in CacheTag::forDynamicNodeAggregate will be tedious as with the NodeIdentity refactoring and the NodeAdress removal, the content stream id will no longer be available.

See https://github.com/neos/neos-development-collection/pull/4892/files#r1531772541

As we want to remove the content stream id from userland it will be hard to fetch and there is (i believe) no gain in preferring it for caching.

@kitsunet
Copy link
Member

I think we have to use workspaceName as we still need to flush based on the workspaceName when the csId changes, probably has broken edge cases with csId around publishing anyways.

@dlubitz
Copy link
Contributor Author

dlubitz commented Mar 20, 2024

This has acually been discussed and we decided to switch it to workspace name. It's on my todo list. But I was also depending on Workspace aware commands etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress 🚧
Status: In Progress
Development

No branches or pull requests

3 participants