Set meta robots noindex if node is of type Neos.Seo:NoindexMixin

[jobee]

This is a (multiple allowed):

• bug
• enhancement
• feature-discussion (RFC)

What you did

added Neos.Seo:NoindexMixin as supertype to a document nodetype to prevent those documents from indexing

Expected Behavior

• not listed in the XML sitemap
• meta robots noindex,follow

Actual Behavior

• not listed in the XML sitemap
• meta robots index,follow

This should probably fix it, what do you think?

prototype(Neos.Seo:MetaRobotsTag) < prototype(Neos.Fusion:Tag) {
    tagName = 'meta'
    attributes {
        name = 'robots'
        content = ${(q(node).property('metaRobotsNoindex') || q(node).is('[instanceof Neos.Seo:NoindexMixin]') ? 'noindex' : 'index') + ',' + (q(node).property('metaRobotsNofollow') ? 'nofollow' : 'follow')}
    }
}

[Sebobo]

This should only happen if you add the super type at a later date as it sets the defaultValue of the property metaRobotsNoindex to true.

But your change of course makes it fully reliable so could you create a PR? The solution looks correct 👍

[jobee]

Hm, you are right, but... in case the property is already set to false (happens if I check > apply > uncheck > apply ?!) a node:repair won't set the defaultValue.

I will provide a PR for full reliability as suggested :)

[Sebobo]

@jobee hi, any update on the PR? :)

[jobee]

@Sebobo sorry, missed that one :) PR will be ready tomorrow