Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Creation dialog does not sort properties by the given position. #3280

Closed
Benjamin-K opened this issue Nov 29, 2022 · 2 comments
Closed
Assignees
Labels
7.3 Bug Label to mark the change as bugfix

Comments

@Benjamin-K
Copy link

Description

The creation dialog shows the properties in the order they were added in the yaml definition and totally ignores the position option. This especially is the case if one nodetype is an extended nodetype of another nodetype.
With the current implementation we have inconsistent positions between the dialog and the sidebar.

Steps to Reproduce

  1. Create a nodetype definition that shows some (at least two) properties in the creation dialog. Add positions to these properties.
  2. Create a second nodetype definition that extends the first one (superTypes) and adds some other properties. Try to set their position to anything between the properties of the first nodetype.
  3. Add a new node of the second nodetype to a page and check the order of the properties in the creation dialog compared to the order of the properties in the sidebar.

Expected behavior

Creation dialog and sidebar both respect the positions given in the nodetypes definition.

Actual behavior

Creation dialog ignores the position properties and sorts properties in the order they were added in the yaml definition. In my case the properties of the first nodetype are shown first, then the properties from the extended nodetype are shown.

Creation dialog:
image

Sidebar:
image

Affected Versions

Neos: 7.3.10

UI: 7.3.7

@grebaldi grebaldi added Bug Label to mark the change as bugfix 7.3 labels Dec 23, 2022
@grebaldi grebaldi self-assigned this Jan 5, 2023
@grebaldi
Copy link
Contributor

grebaldi commented Jan 5, 2023

This is faulty behavior of the CreationDialogPostprocessor over at Neos.Neos. I'll fix it there.

Update: Here we go: neos/neos-development-collection#3992

@Benjamin-K
Copy link
Author

This is fixed with the latest Neos release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

No branches or pull requests

2 participants