New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Target workspace handling during indexing #26
Changes from all commits
6be2747
72bac06
6470d2b
1f595a5
9369b8a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,7 @@ abstract class AbstractNodeIndexer implements NodeIndexerInterface | |
* Called by the Flow object framework after creating the object and resolving all dependencies. | ||
* | ||
* @param integer $cause Creation cause | ||
* @throws \Neos\Flow\Configuration\Exception\InvalidConfigurationTypeException | ||
*/ | ||
public function initializeObject($cause) | ||
{ | ||
|
@@ -91,6 +92,8 @@ protected function evaluateEelExpression($expression, NodeInterface $node, $prop | |
* @param string $fulltextExtractionExpression | ||
* @param array $fulltextIndexOfNode | ||
* @throws IndexingException | ||
* @throws \Neos\ContentRepository\Exception\NodeException | ||
* @throws \Neos\Eel\Exception | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These exceptions are thrown in called methods - we only annotate the exceptions thrown here (maybe you should reconfigure your phpStorm :)) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Well, do we? Says who?
Actually those warnings bother me, but I don't want to disable the inspection (since on actually Anyway, let's handle that in https://discuss.neos.io/t/to-throws-or-not-to-throws-indirect-exceptions/3018 – ok? |
||
*/ | ||
protected function extractFulltext(NodeInterface $node, $propertyName, $fulltextExtractionExpression, array &$fulltextIndexOfNode) | ||
{ | ||
|
@@ -118,6 +121,9 @@ protected function extractFulltext(NodeInterface $node, $propertyName, $fulltext | |
* @param array $fulltextData | ||
* @param \Closure $nonIndexedPropertyErrorHandler | ||
* @return array | ||
* @throws IndexingException | ||
* @throws \Neos\ContentRepository\Exception\NodeException | ||
* @throws \Neos\Eel\Exception | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No Exceptions thrown ... |
||
*/ | ||
protected function extractPropertiesAndFulltext(NodeInterface $node, array &$fulltextData, \Closure $nonIndexedPropertyErrorHandler = null) | ||
{ | ||
|
@@ -169,4 +175,4 @@ protected function isFulltextEnabled(NodeInterface $node) | |
|
||
return false; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this method doesn't throw an exception