-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors more vivid in neovide than elsewhere #1102
Comments
Right, yes, I just tried it out here too by just trying a solid block where it is more clearly visible, and that got me the same result. The question is the non-subpixel version generally preferable or should I just make a private fork for my own use. |
I think some people reported that the fonts look "weird" and this might be the cause. I'm pretty sure non-subpixel is better (or at least more people would prefer it), but I might be wrong. If there isn't a big majority, maybe we could do an option to set which one to use. |
Well I tried around a bit but I'll give up on making a setting for tonight. The issue is that the whole font renderer is initialized very early on it seems, even before the settings are read from neovims config, meaning that tweaking anything there won't really help unless you make it update properly. Given that I honestly barely use Rust at all and am not that familiar with the code I'll leave it at that. I just statically changed it for myself for now, which fixes the problem for me. |
Ok so it seems that the issues is fixed for now and nobody has really asked for subpixel font stuff from us since so I'm going to close this. |
Sorry for commenting on a closed issue, but I have this issue as well. Would you please tell us in more depth how you solved it locally @JeWe37 ? |
I don't use Neovide anymore, but it seems that this has become configurable since then, see here |
|
Can you check if it's the font or the colors in general, by setting the background color for example You can do the same for the fonts by setting a big font to rule out any edging issues and then use Edit: At least on Windows with the default settings the background is exactly as specified, and the fonts are the same or darker (with a darker background). Subpixel antialiasing, which could make some pixels brighter is no longer the default on any platform. |
It depends on how you define "correct" The output from Neovide is 250,128,114=#FA8072, exactly as specified in linear RGB values. On the other terminals the output is converted to sRGB 232,137,118=#E88976 Apparently the built in macOS terminal chose to use sRGB for some unexplainable reason, and the other terminal emulators were forced to follow.
That also means that a color scheme designed on Linux or Windows will look wrong on macOS and vice-versa. But apparently that's what macOS users want, so I'm not opposing creating an option to enable sRGB output, but I'm not sure about making that the default. I acknowledge that the sRGB format is superior, especially since most new monitors are wide gamut, but terminals have traditionally used linear RGB. Most web browsers use sRGB though, and therefore the sRGB colors will match the ones you see in a color picker in the web browser, while the linear colors match the colors you see in most other applications including simple painting programs like Microsoft Paint. I will however, not re-open this issue, since it was originally clearly about the fonts. If you want sRGB support, you should create a new issue for it. |
Describe the bug
Colors with the same color scheme appear differently as in terminal problems running raw neovim.
To Reproduce
Steps to reproduce the behavior:
The problem is most visible with themes that are not too vibrant by default(but as far as I can tell it is still present everywhere). In the screenshots I am using the shusia option of the sonokai colorscheme.
Expected behavior
The colors should match those of terminal applications
Screenshots
![image](https://user-images.githubusercontent.com/26010054/146772953-687fa0cf-453f-4190-acc5-da413bf1b7da.png)
Desktop (please complete the following information):
Additional context
I previously used the older Vulkan version of neovide where this issue did not appear. As is, it makes it hard to properly match color schemes and at least in my eyes, the more vivid colors stand out far too much.
The text was updated successfully, but these errors were encountered: