Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovide maximized does not work in wayland #2137

Closed
busaster opened this issue Nov 17, 2023 · 5 comments
Closed

neovide maximized does not work in wayland #2137

busaster opened this issue Nov 17, 2023 · 5 comments
Labels
bug Something isn't working status:needs-response issue or PR needs further information from author

Comments

@busaster
Copy link

busaster commented Nov 17, 2023

Linux Ubuntu 22.04.3 LTS with wayland

Neoide version 0.10.0-dev

Launch command "neoide --maximized" from command line or via a .desktop file
The windows pops up but it is not maximized.

image

@busaster busaster added the bug Something isn't working label Nov 17, 2023
@fredizzimo
Copy link
Member

On my system this happens maybe once in ten tries. Most of the time it's maximized correctly.

In any case it looks like a winit, wayland or gnome bug, but probably need a bit more investigation before reporting. I'm currently on gnome and haven't tested with any other DE/window manger yet.

I can't repeat it with the maximized winit example, so I don't think changing the maximized state is the trigger, it's probably the fact that we call show and maximized right after each other.

@mati865
Copy link

mati865 commented Dec 19, 2023

FYI Alacritty has the same issue, it supposedly has been fixed on the master but hasn't made it to the release yet: alacritty/alacritty#6184

@fredizzimo
Copy link
Member

Can you test if this is fixed on main? I think it might have been fixed by

But I don't have a computer to test on for one week more.

@fredizzimo fredizzimo added the status:needs-response issue or PR needs further information from author label Jan 13, 2024
@mati865
Copy link

mati865 commented Jan 21, 2024

I haven't observed it since that PR was merged to main branch.

@fredizzimo
Copy link
Member

Nice, I'm going to close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:needs-response issue or PR needs further information from author
Projects
None yet
Development

No branches or pull requests

3 participants