-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll animations being skipped when using some plugins #2203
Comments
I have debugged the
The scroll animation stops because we get a In this case the Window is neither moved or resized though, both the position and size are the same as previously. But Neovim sends the command because there's a very short lived window, which doesn't even exist for a single frame, so it's never actually created, or shown, just hidden and destroyed. And since that is non-floating window, it has to reposition the main window.
I think that could be considered a Neovim bug, it should not send these commands. But in order to report that we still need to figure out why they are sent, and why a temporary non-floating window is created. On the Neovide side, I will fix it so that position updates don't cause the scrolling to stop. NOTE: I have not yet checked what |
Both were caused by the same issue, and #2208 should fix it. |
Just tested the PR and it works great for me. Thank you for fixing this very quickly! |
I'm using 0.12.1 and scroll animations are working perfectly so far with plugins those were previously problematic. |
I don't understand how it does though, since the scrollback buffer should be wrong after clearing, and some of the scrolled lines will be the wrong ones. But maybe it happens so fast that it's not noticeable? A longer |
Actually, after taking a second look those lines will be empty, not wrong. So that probably makes it look better. |
I'm not sure what's the exact correct/intended behavior, so here's a screen recording with scroll animation length set to 1.5: rec.mp4 |
Yea, that looks correct, I'm just not sure how at the moment. |
Just coming here to comment that I'm having the same exact issue with tree sitter context, on the latest version |
Describe the bug
Scroll animations do not play correctly with some plugins in 0.12, even though it used to work in previous versions. When this happens, scrolling is instant, instead of the viewport scrolling smoothly.
To Reproduce
Expected behavior
Scroll animations play like it used to in previous versions
Screenshots
Scrolling line by line with nvim-scrollview:
0.12.0-line.mp4
Even if I disable nvim-scrollview, scroll animation is skipped when nvim-treesitter-context floating buffer disappears (when pressing C-u in this case):
0.12.0-context.mp4
Doing the same in 0.11.1:
0.11.1-line.mp4
0.11.1-context.mp4
Desktop (please complete the following information):
Please run
neovide --log
and paste the contents of the.log
file created in the current directory here:neovide_rCURRENT.log
The text was updated successfully, but these errors were encountered: