Fedora 20, build fails, /usr/bin/dtrace invalid option, libuv

[alxgrtnstrngl]

Trying to build on Fedora 20 and I have all the buildeps and running:

$ make

Generates build error:

[ 17%] Performing build step for 'libuv'
make[4]: Entering directory `/home/$USER/Projects/neovim/.deps/build/src/libuv-build'
  GEN      include/uv-dtrace.h
/usr/bin/dtrace invalid option -xnolibs
Usage /usr/bin/dtrace [--help] [-h | -G] [-C [-I<Path>]] -s File.d [-o <File>]
make[4]: *** [include/uv-dtrace.h] Error 1
make[4]: Leaving directory `/home/$USER/Projects/neovim/.deps/build/src/libuv-build'
make[3]: *** [/home/$USER/Projects/neovim/.deps/build/src/libuv-stamp/libuv-build] Error 2
make[3]: Leaving directory `/home/$USER/Projects/neovim/.deps/build/third-party'
make[2]: *** [CMakeFiles/libuv.dir/all] Error 2
make[2]: Leaving directory `/home/$USER/Projects/neovim/.deps/build/third-party'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/$USER/Projects/neovim/.deps/build/third-party'
make: *** [deps] Error 2

What could the problem be and how can I solve this?

---

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

[justinmk]

Looks like a libuv issue: joyent/libuv#1478

[alxgrtnstrngl]

@justinmk I went into ".deps/build/src/libuv" and edited "Makefile.am" at line 315-316:

if HAVE_DTRACE
include/uv-dtrace.h: src/unix/uv-dtrace.d
#   $(AM_V_GEN)$(DTRACE) $(DTRACEFLAGS) -h -xnolibs -s $< -o $(top_srcdir)/$@
    $(AM_V_GEN)$(DTRACE) $(DTRACEFLAGS) -h -s $< -o $(top_srcdir)/$@
endif

Removing the '-xnolibs' option allows it to build and confirmed the program runs.

[justinmk]

Per joyent/libuv#1478 (comment) , we may just want to disable dtrace probes in cmake altogether.

Also, joyent/libuv#1478 (comment) indicates that Fedora removes this already, maybe if you upgrade Fedora the problem will go away?

[alxgrtnstrngl]

we may just want to disable dtrace probes in cmake altogether.

I'm not familiar with how cmake pulls in the ".deps", but I think that would be the best route. Maybe run a script on the makefile in the configure that removes the '-xnolibs' reference for those on Linux. The joyent/libuv#1478 (comment) @nalimilan mentioned:

Currently I'm calling sed to remove this argument from the Makefile.

[jszakmeister]

Perhaps this patch would do it?

diff --git a/third-party/CMakeLists.txt b/third-party/CMakeLists.txt
index 793be31..f0a83bf 100644
--- a/third-party/CMakeLists.txt
+++ b/third-party/CMakeLists.txt
@@ -78,7 +78,7 @@ if(USE_BUNDLED_LIBUV)
       -P ${CMAKE_CURRENT_SOURCE_DIR}/cmake/DownloadAndExtractFile.cmake
     CONFIGURE_COMMAND sh ${DEPS_BUILD_DIR}/src/libuv/autogen.sh &&
       ${DEPS_BUILD_DIR}/src/libuv/configure --with-pic --disable-shared
-        --prefix=${DEPS_INSTALL_DIR} CC=${DEPS_C_COMPILER}
+        --disable-dtrace --prefix=${DEPS_INSTALL_DIR} CC=${DEPS_C_COMPILER}
     INSTALL_COMMAND ${MAKE_PRG} install)
   list(APPEND THIRD_PARTY_DEPS libuv)
 endif()

[jszakmeister]

I should add that I'd rather not disable dtrace completely--it can be a useful diagnostic tool. Perhaps we could detect the version of dtrace and filter out -xnolibs if the version is sufficient.

[rustushki]

Can confirm that the patch from @jszakmeister does workaround the problem. I was able to install in Fedora 20 after manually applying the patch in linuxbrew's debug mode.

[rustushki]

Can confirm this is also a problem in Fedora 19. Looks like the systemtap-sdt-devel package entered stable on 2014/10/08.

[justinmk]

Looks like joyent/libuv#1478 is getting mired in a philosophical debate, so we'll probably need to patch around this ourselves.

[justinmk]

Fixed by libuv/libuv#3 . When we update to that version of libuv we can close this.

[ghost]

I assume this can be closed

[jszakmeister]

Sure can. Thanks.