Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree-sitter based highlight may be inefficient #18108

Closed
vigoux opened this issue Apr 14, 2022 · 2 comments · May be fixed by #18109
Closed

Tree-sitter based highlight may be inefficient #18108

vigoux opened this issue Apr 14, 2022 · 2 comments · May be fixed by #18109
Labels
highlight performance issues reporting performance problems treesitter
Milestone
0.10

Comments

@vigoux
Copy link
Member

vigoux commented Apr 14, 2022 •
edited
Loading

The tree-sitter highlighter code has been written a while ago, and it attempts to overcome an issue at that time about some captures not being returned when limiting the range over which the query runs.

Since some time now, this limitation is not true anymore, and we might need to rewrite and refactor some parts of that (for the better).
@vigoux vigoux added performance issues reporting performance problems treesitter highlight labels Apr 14, 2022
@clason clason changed the title Tree-sitter based highlight may be ineficient Tree-sitter based highlight may be inefficient Apr 14, 2022
@vigoux vigoux modified the milestone: unplanned Apr 14, 2022
@clason clason added this to the 0.8 milestone Apr 14, 2022
@vigoux vigoux mentioned this issue Apr 14, 2022
Open
@akinsho akinsho mentioned this issue Jun 16, 2022
Closed
@bfredl bfredl modified the milestones: 0.9, 0.10 Apr 7, 2023
@bew
Copy link
Sponsor Contributor

bew commented Sep 16, 2023

The tree-sitter highlighter code has been written a while ago, and it attempts to overcome an issue at that time about some captures not being returned when limiting the range over which the query runs.

Are there still things to do related to this?
Would be nice to have a list. If this list exists somewhere else, maybe close this issue?

@justinmk
Copy link
Member

@bew see #22426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
highlight performance issues reporting performance problems treesitter
Projects
None yet
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

refactor(treesitter): rely more on ts correctness vigoux/neovim
6 participants
@justinmk @bfredl @clason @lewis6991 @bew @vigoux