Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: Support for typescript / typescript-language-server's "Go to Source Definition" command #28328

Closed
ajbuz opened this issue Apr 14, 2024 · 5 comments
Labels
enhancement feature request lsp

Comments

@ajbuz
Copy link

ajbuz commented Apr 14, 2024

Problem

It appears this hasn't been discussed here but TypeScript 4.7 adds support for a new editor command called "Go To Source Definition" _typescript.goToSourceDefinition and It would be really helpful if you could also provide support for it.
More info & demo can be found in release notes.

Thank you.

Expected behavior

__

@ajbuz ajbuz added the enhancement feature request label Apr 14, 2024
@justinmk justinmk added the lsp label Apr 14, 2024
@clason
Copy link
Member

clason commented Apr 14, 2024

That's not in the LSP specification, though, so out of scope for us. @MariaSolOs

@clason clason closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
@justinmk
Copy link
Member

We will not add explicit support for server-specific commands. However we do need a general mechanism that makes it easy for users (and nvim-lspconfig) to:

  1. iterate through discovered server capabilities / commands
  2. define aliases to commands, in a non-verbose way

The current situation with nvim-lspconfig is that 10 lines of code are needed to define commands. That's unsustainable.

See also neovim/nvim-lspconfig#1937

@justinmk
Copy link
Member

@clason unless we have an existing issue, I'd like to keep this open to track the above idea

@clason
Copy link
Member

clason commented Apr 14, 2024

I would strongly prefer a targeted issue about general server-specific commands. Adding individual commands is out of scope, and re-using this issue will give the wrong impression.

@justinmk
Copy link
Member

I would strongly prefer a targeted issue about general server-specific commands

Stubbed in #28329 , improvements welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature request lsp
Projects
None yet
Development

No branches or pull requests

3 participants