[d-default behaves differently from explicit mapping

[xudyang1]

Problem

since v0.10.0, [d and ]d are mapped to vim.diagnostic.goto_next() and vim.diagnostic.goto_prev(). The default behavior of [d and ]d only moves the cursor to the diagnostics.

Explicitly mapping [d and ]d, vim.keymap.set("n", "[d", vim.diagnostic.goto_prev), moves the cursor AND opens the floating diagnostic window.

Steps to reproduce

Tested with and without explicit keymap:

minimal.lua:

local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

local plugins = {
  {
    "neovim/nvim-lspconfig",
    event = { "BufReadPost", "BufNewFile" },
    dependencies = {
      {
        "williamboman/mason.nvim",
        opts = {
          -- custom ensure_installed
          ensure_installed = {
            -- lua_ls
            "lua-language-server",
          },
        },
        config = function(_, opts)
          require("mason").setup(opts)
          local mr = require("mason-registry")
          local function ensure_installed()
            for _, tool in pairs(opts.ensure_installed) do
              local p = mr.get_package(tool)
              if not p:is_installed() then
                p:install()
              end
            end
          end

          mr.refresh(ensure_installed)
        end,
      },
    },
    config = function()
      require("lspconfig").lua_ls.setup({})
    end,
  },
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

-- comment / uncomment the following keymaps
vim.keymap.set("n", "[d", vim.diagnostic.goto_prev)
vim.keymap.set("n", "]d", vim.diagnostic.goto_next)

Expected behavior

The default behavior open the floating diagnostic window.

Neovim version (nvim -v)

0.10.0

Vim (not Nvim) behaves the same?

not available in vim

Operating system/version

WSL ubuntu 22.04

Terminal name/version

windows terminal 1.21.1272.0

$TERM environment variable

xterm-256color

Installation

appimage

[wookayin]

It is by design that floating window is disabled by default. See #16230.

]d and [d are mapped to:

vim.diagnostic.goto_next({ float = false })
vim.diagnostic.goto_prev({ float = false })

respectively. You should use your own custom mapping if you wish floating window is also opened.