Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic property for other groups is forcedly ignored in italic string #28945

Closed
sharpchen opened this issue May 23, 2024 · 1 comment
Closed
Labels
closed:question issues that are closed as usage questions

Comments

@sharpchen
Copy link

sharpchen commented May 23, 2024

Problem

Italic boolean property for highlight group(like @punctuation.special, @punctuation.bracket) are ignored inside a italic string. They are forcedly styled as italic.

image

Steps to reproduce

  • make sure install treesitter parser for javascript
  • create a js file and paste code sample
testEmails.forEach(email => {                                                                                    
    console.log(`Is "${email}" a valid email? ${isValidEmail(email)}`);                                            
});
  • switch to a colorscheme that have string non-italic
  • :hi @string gui=italic

Expected behavior

style as it is

Neovim version (nvim -v)

NVIM v0.10.0

Vim (not Nvim) behaves the same?

no idea how to reproduce in vim

Operating system/version

windows 10

Terminal name/version

alacritty 0.13.2

$TERM environment variable

xterm-256color

Installation

scoop

@sharpchen sharpchen added the bug issues reporting wrong behavior label May 23, 2024
@zeertzjq
Copy link
Member

zeertzjq commented May 23, 2024

Use nocombine in the non-italic groups

@zeertzjq zeertzjq added closed:question issues that are closed as usage questions and removed bug issues reporting wrong behavior highlight labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:question issues that are closed as usage questions
Projects
None yet
Development

No branches or pull requests

3 participants