Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal-mode events: InsertCharPre #5018

Open
justinmk opened this issue Jul 7, 2016 · 3 comments
Open

terminal-mode events: InsertCharPre #5018

justinmk opened this issue Jul 7, 2016 · 3 comments
Labels
complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md enhancement feature request needs:design needs a clear design proposal terminal built-in :terminal or :shell
Milestone
backlog

Comments

@justinmk
Copy link
Member

justinmk commented Jul 7, 2016 •
edited

Expected behaviour

  • When :term buffer contents change while user is in "terminal mode" (insert mode), insert-mode events such as TextChangedI, CursorMovedI, InsertCharPre should fire.

Update: it makes sense to implement InsertCharPre because Nvim knows exactly what the user sends. But TextChangedI and CursorMovedI are less obvious, because the terminal program may change those arbitrarily.
@justinmk justinmk added the terminal built-in :terminal or :shell label Jul 7, 2016
@justinmk justinmk added this to the todo milestone Jul 7, 2016
@justinmk justinmk changed the title :term buffer does not fire TextChangedI nor CursorMovedI :term buffer does not fire TextChangedI, CursorMovedI, InsertCharPre Jul 23, 2016
@doraemon96

This comment has been minimized.

Sign in to view
@justinmk justinmk added enhancement feature request needs:design needs a clear design proposal closed:wontfix current behavior is by design, and change is not desired labels Feb 8, 2018
@justinmk
Copy link
Member Author

justinmk commented Feb 8, 2018

This probably isn't a good idea. "Text changed" in a terminal job is meaningless.

An alternative is #5023 , i.e. support hooking into the streams of an existing job.

@justinmk justinmk closed this as completed Feb 8, 2018
@dm1try dm1try mentioned this issue Mar 7, 2019
Closed
@justinmk justinmk removed the closed:wontfix current behavior is by design, and change is not desired label Mar 7, 2019
@justinmk justinmk changed the title :term buffer does not fire TextChangedI, CursorMovedI, InsertCharPre terminal-mode events: InsertCharPre, TextChangedI, CursorMovedI Mar 7, 2019
@justinmk justinmk reopened this Mar 7, 2019
@justinmk
Copy link
Member Author

justinmk commented Mar 7, 2019

Re-opened for InsertCharPre.

@justinmk justinmk added the complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md label Mar 7, 2019
@justinmk justinmk mentioned this issue Mar 13, 2019
Open
@ibhagwan ibhagwan mentioned this issue Dec 20, 2021
Closed
@justinmk justinmk mentioned this issue Oct 11, 2022
Closed
@zeertzjq zeertzjq changed the title terminal-mode events: InsertCharPre, TextChangedI, CursorMovedI terminal-mode events: InsertCharPre Feb 5, 2023
@ColinKennedy ColinKennedy mentioned this issue Nov 18, 2023
Closed
@glepnir glepnir mentioned this issue Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md enhancement feature request needs:design needs a clear design proposal terminal built-in :terminal or :shell
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

fix(terminal): can trigger insercharpre event glepnir/neovim
2 participants
@justinmk @doraemon96