Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgpack & shada functional tests fail with TZ=GMT-14 #7625

Open
jamessan opened this issue Nov 23, 2017 · 5 comments
Open

msgpack & shada functional tests fail with TZ=GMT-14 #7625

jamessan opened this issue Nov 23, 2017 · 5 comments
Labels
Milestone

Comments

@jamessan
Copy link
Member

Steps to reproduce

env TZ=GMT-14 make functionaltest

Actual behaviour

[1m�[31m[  ERROR   ]�[0m�[0m �[1m17�[0m errors, listed below:
�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...neovim-0.2.2/2nd/test/functional/plugin/msgpack_spec.lua�[0m @ �[36m284�[0m: �[1mIn autoload/msgpack.vim function msgpack#strptime works�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'nvim_eval'
	...neovim-0.2.2/2nd/test/functional/plugin/msgpack_spec.lua:287: in function <...neovim-0.2.2/2nd/test/functional/plugin/msgpack_spec.lua:284>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1362�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with multiple items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1363: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1362>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1424�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with header items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1425: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1424>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1487�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with search pattern items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1488: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1487>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1602�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with replacement string items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1603: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1602>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1641�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with history entry items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1642: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1641>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1738�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with register items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1739: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1738>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1837�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with variable items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1838: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1837>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1878�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with global mark items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1879: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1878>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1900�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with jump items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1901: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1900>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m1922�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with buffer list items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1923: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1922>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m2023�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with local mark items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2024: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2023>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m2045�[0m: �[1mIn autoload/shada.vim function shada#strings_to_sd works with change items�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:1341: in function 'strings2sd_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2046: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2045>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m2078�[0m: �[1mIn autoload/shada.vim function shada#get_binstrings works�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'shada#get_binstrings'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2070: in function 'getbstrings_eq'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2084: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2078>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m2249�[0m: �[1mIn plugin/shada.vim event BufWriteCmd works�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2266: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2249>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m2305�[0m: �[1mIn plugin/shada.vim event FileWriteCmd works�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2322: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2305>

�[1m�[31m[  ERROR   ]�[0m�[0m �[36m...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua�[0m @ �[36m2344�[0m: �[1mIn plugin/shada.vim event FileAppendCmd works�[0m
./test/functional/helpers.lua:93: internal-start-string:Internal error: start > string

stack traceback:
	./test/functional/helpers.lua:93: in function 'request'
	./test/functional/helpers.lua:151: in function 'nvim_command'
	...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2364: in function <...d/neovim-0.2.2/2nd/test/functional/plugin/shada_spec.lua:2344>

Expected behaviour

Passing tests

@fmoralesc
Copy link
Contributor

fmoralesc commented Nov 23, 2017

So, what happens with GMT-13? Neither it nor GMT-14 should be valid values, right?

EDIT: GMT-14 as in GMT minus 14, right?

@justinmk justinmk added the test label Nov 23, 2017
@justinmk
Copy link
Member

Could be a bug in runtime/autoload/msgpack.vim s:msgpack_dict_strptime().

@justinmk justinmk added the runtime funtime label Nov 23, 2017
@justinmk justinmk added this to the todo milestone Nov 23, 2017
@jamessan
Copy link
Member Author

So, what happens with GMT-13?

The same.

Neither it nor GMT-14 should be valid values, right?

According to the contents of /usr/share/zoneinfo/Etc they are:

$ ls /usr/share/zoneinfo/Etc
GMT   GMT-0  GMT-1  GMT-10  GMT-11  GMT-12  GMT-13  GMT-2  GMT-3  GMT-4  GMT-5  GMT-6  GMT-7  GMT-8  GMT-9  Greenwich  Universal  Zulu
GMT0  GMT+0  GMT+1  GMT+10  GMT+11  GMT+12  GMT-14  GMT+2  GMT+3  GMT+4  GMT+5  GMT+6  GMT+7  GMT+8  GMT+9  UCT        UTC

@fmoralesc
Copy link
Contributor

Wait.... in that list it goes from GMT-14 to GMT+12. I thought timezones went from GMT(UTC)-12 to GMT(UTC)+14 (https://en.wikipedia.org/wiki/List_of_UTC_time_offsets). So, what is going on here?

@mhinz
Copy link
Member

mhinz commented Nov 23, 2017

I found the explanation here: https://github.com/eggert/tz/blob/master/etcetera#L36-L42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants