Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor settings #167

Closed
protoroto opened this issue Aug 25, 2023 · 0 comments · Fixed by #168
Closed

Refactor settings #167

protoroto opened this issue Aug 25, 2023 · 0 comments · Fixed by #168
Assignees
@protoroto
Labels
type: feature

Comments

@protoroto
Copy link
Member

Description

We need to be able to consistently use override_settings in tests, because otherwise we have to constantly redefine settings in an ugly way.

Proposed solution

Use something like https://github.com/nephila/djangocms-blog/blob/develop/djangocms_blog/settings.py#L630C1-L634C73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@protoroto protoroto

Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor settings to make override_settings in tests more consistent protoroto/django-meta
1 participant
@protoroto