Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination #119

Merged
merged 2 commits into from Apr 23, 2023
Merged

Fix pagination #119

merged 2 commits into from Apr 23, 2023

Conversation

yakky
Copy link
Member

@yakky yakky commented Oct 23, 2021

Description

Page parameter was not passed to querystring, thus pagination failed

Ensure page parameter is actually passed to query parameters

References

Fix #116

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

Ensure page parameter is actually passed to query parameters
@yakky yakky force-pushed the bugfix/issue-116-fix-pagination branch from f7b7231 to 7d3a38b Compare October 23, 2021 09:34
@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #119 (a35adf2) into master (f448eda) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files           8        8           
  Lines         876      878    +2     
  Branches       63       64    +1     
=======================================
+ Hits          844      846    +2     
  Misses         19       19           
  Partials       13       13           
Flag Coverage Δ
unittests 96.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
taiga/models/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f448eda...a35adf2. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 23, 2021

Coverage Status

Coverage increased (+0.005%) to 97.829% when pulling a35adf2 on bugfix/issue-116-fix-pagination into f448eda on master.

@yakky yakky merged commit d03522b into master Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagination, page always returns the first page
2 participants