Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMR Verify Return Type #138

Closed
aszepieniec opened this issue Aug 1, 2023 · 1 comment
Closed

MMR Verify Return Type #138

aszepieniec opened this issue Aug 1, 2023 · 1 comment
Assignees
@Sword-Smith
Labels
⏭️ breaking change Breaking change, will require an increment of the major version number. E.g: 0.3.0 -> 0.4.0 good first issue Good for newcomers

Comments

@aszepieniec
Copy link
Collaborator

MmrMembershipProof::verify returns a bool and possibly a hash.

Verify a membership proof for an MMR. If verification succeeds, return the final state of the accumulator hash.

It should return just a bool. Methods that need the hash also need to call a different function. This is a small change but percolates far down.
@aszepieniec aszepieniec added good first issue Good for newcomers ⏭️ breaking change Breaking change, will require an increment of the major version number. E.g: 0.3.0 -> 0.4.0 labels Aug 1, 2023
@Sword-Smith
Copy link
Member

Closed by 2a331dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sword-Smith Sword-Smith

Labels
⏭️ breaking change Breaking change, will require an increment of the major version number. E.g: 0.3.0 -> 0.4.0 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aszepieniec @Sword-Smith