Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

考虑将开发中的代码更新为 SNAPSHOT 版本 #83

Closed
RobinGG opened this issue Nov 22, 2019 · 2 comments
Closed

考虑将开发中的代码更新为 SNAPSHOT 版本 #83

RobinGG opened this issue Nov 22, 2019 · 2 comments

Comments

@RobinGG
Copy link
Contributor

RobinGG commented Nov 22, 2019

环境

  • discovery.version: 5.5.2

问题描述

今天在尝试通过 discovery-springcloud-example-gateway 示例搭建一个 Demo 服务。然后发现在 String environment = pluginAdapter.getServerEnvironment(server); 报错。查看接口类,发现没有这个接口,但是 example 里面确实存在这个接口。版本号也符合,都是 5.5.2。进一步查看后发现是昨天新提交的代码(咋就这么巧),但是版本号并没有更新为 5.5.3-SNAPSHOT,就导致了代码不一致的情况出现

期望

在一个版本正式发布以后,后续的新功能开发版本号应该更新,比如 5.5.2-RELEASE --> 5.5.3-SNAPSHOT

@HaojunRen
Copy link
Member

HaojunRen commented Nov 22, 2019 via email

@RobinGG
Copy link
Contributor Author

RobinGG commented Nov 25, 2019

更新到 5.5.3 以后确实没有问题了
不过我观察到 5.x.x 的分支代码仍然是在一个 RELEASE 的版本
我还是建议:如果 5.x.x 分支仍然考虑有新功能开发的话,希望可以在 SNAPSHOT 分支开发

@RobinGG RobinGG closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants