Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you implemented Combined Sampling(Sec 4.4 in the paper)? #253

Open
flow-specter opened this issue Aug 28, 2023 · 4 comments
Open

Have you implemented Combined Sampling(Sec 4.4 in the paper)? #253

flow-specter opened this issue Aug 28, 2023 · 4 comments

Comments

@flow-specter
Copy link

Awesome work! I wanna ask that if you have implemented Combined Sampling(Sec 4.4 in the paper), which combines occupancy grid and proposal networks?

@fyang235
Copy link

+1

@AIBluefisher
Copy link

I'm also curious about how the combined sampling is implemented. It is not clear whether the proposal net uses the transmittance obtained from the occupancy grid sampler for importance sampling, or just simply utilizes the occupancy grid to skip empty space. Could you please make it clear here? @liruilong940607

@wanger-666
Copy link

+1

@liruilong940607
Copy link
Collaborator

Hi I'm not supporting that in this repo because I was hacking some CUDA code to make that happen, but I don't want to mess up the API in this repo.

The proper combination is just like you said, that should be the proposal net uses the transmittance obtained from the occupancy grid sampler for importance sampling. However what we implemented is a simplified version of that, which we simply use the occ grid to return a per-ray near far, and use the per-ray near far to do importance sampling for proposal net.

This is essentially a simplified version of occ grid estimator that assumes linear CDF between the per-ray near far plane, and CDF = 0 or 1 for the regions outside of the near far range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants