Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements OAuth Sign In newWindow and sameWindow modes #61

Merged
merged 4 commits into from
Nov 27, 2016

Conversation

roterski
Copy link
Contributor

Hey @neroniaky,

I've implemented OAuth Sign In flow with devise_token_auth supporting two modes: 'sameWindow' and 'newWindow'. I based my code on the ng-token-auth implementation.

You can see it working in action:
deployed here http://ng2auth-router-starter.netlify.com/
front-end code: https://github.com/piotrkaczmarek/ng2AuthRouterStarter
server code: https://github.com/piotrkaczmarek/ng2ars-api

In few days, I will write it up and add a section to the readme.

For now, I would be glad if you reviewed my code. Happy to hear your feedback!

@neroniaky
Copy link
Owner

@piotrkaczmarek thanks a lot! I was hoping to see your modifications as a PR, because I couldn't get it to work myself. I gonna take a look at it as soon as possible.
With 0.2.0 I integrated a "quickstart" GUI (not yet in the readme). Maybe you can take a look at it too.

@neroniaky neroniaky merged commit cec1235 into neroniaky:master Nov 27, 2016
@neroniaky
Copy link
Owner

@piotrkaczmarek thank you a lot! Mind if I put your name under the contributors section of the README?

@roterski
Copy link
Contributor Author

@neroniaky that would be great! Thanks!

neroniaky added a commit that referenced this pull request Jun 19, 2022
Implements OAuth Sign In newWindow and sameWindow modes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants