Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing import: tags2sst in pssid/identify.py #99

Open
nschneid opened this issue Jun 16, 2023 · 1 comment
Open

missing import: tags2sst in pssid/identify.py #99

nschneid opened this issue Jun 16, 2023 · 1 comment

Comments

@nschneid
Copy link
Contributor

Pointed out by @WesScivetti. @jakpra do you happen to remember if we renamed that file or what?

@jakpra
Copy link
Member

jakpra commented Jun 17, 2023

I don't remember, but it looks like (a) the needed function (tags2sst.render) should be mwerender.render (at least it has the same call signature - not sure if the output is exactly what we want here), and (b) it is only called if args.sst==True, i.e., if the requested output format is *.sst, which I think is deprecated, so you may as well just comment out the import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants