Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware filter for devices should populate from devices #684

Open
jjcarstens opened this issue Nov 3, 2020 · 2 comments
Open

firmware filter for devices should populate from devices #684

jjcarstens opened this issue Nov 3, 2020 · 2 comments

Comments

@jjcarstens
Copy link
Collaborator

The firmware filter of the device index page is not that useful. It only lists firmware versions of which you still have a firmware record for. But firmwares get cleaned up and sometimes you have devices connecting which are on an old firmware that doesn't exist.

This makes it so you can't filter devices on reported firmware versions. You also can't filter devices that are "unknown" firmware (have yet to connect). In the screenshot below, you can see I have multiple firmwares that aren't listed in the firmware filter dropdown

image

It would be nice if we could populate the filter option based on all versions reported from devices on the product.

@Mrjaco12
Copy link
Contributor

Mrjaco12 commented Nov 3, 2020

I agree that updating this in some way would be a good idea. I just want to add context here about how we arrived at the way it works now. Since the live view only tracks devices that are being displayed, generating a list of firmware ids from the list of devices that the liveview knows about is not sufficient. The alternative is to fetch firmware versions for each device when the liveview mounts, which we decided was kinda expensive and it wouldn't necessarily have all the correct data if devices were added or removed while the user was on the page. It was also slightly more complicated to factor in filtering for the "unknown" state. So given all that we elected to use the easiest approach.

To summarize, there are a few considerations about tradeoffs that need to be decided before this feature can be fully implemented but I think this issue is bringing things in the right direction.

@jjcarstens
Copy link
Collaborator Author

Personally, I think its a worthwhile tradeoff to do a single DB query to select a single field from applicable device firmwares for the versions on mount. Or, it can be done when opening the "show filter" button as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants