Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: as per React it should be possible to change roots #33

Open
Havunen opened this issue Jan 20, 2018 · 0 comments
Open

Bug: as per React it should be possible to change roots #33

Havunen opened this issue Jan 20, 2018 · 0 comments

Comments

@Havunen
Copy link

Havunen commented Jan 20, 2018

NervJS:
https://codesandbox.io/s/m31owy1wvj (link fixed)

React: ( See console logs )
https://jsfiddle.net/a2ay2fh6/

expected result: Nerv should be able to change root nodes.
For more tests on similar manner see Inferno test cases here:
https://github.com/infernojs/inferno/blob/master/packages/inferno-create-element/__tests__/components.spec.jsx#L2528-L3219

Hopefully you find good way to fix this :) So we can improve inferno too. Inferno currently updates vNode parents after setState to have this working + cloning vNodes before patching.. Which has obvious effect in performance

@Havunen Havunen changed the title as per React it should be possible to change roots Bug: as per React it should be possible to change roots Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant