Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier doesn't verify unions #33

Open
krojew opened this issue Oct 22, 2019 · 2 comments
Open

Verifier doesn't verify unions #33

krojew opened this issue Oct 22, 2019 · 2 comments

Comments

@krojew
Copy link

krojew commented Oct 22, 2019

Verifier doesn't seem to check union bounds, thus resulting in a panic when unwrapping unsupported type.

@doitian
Copy link
Member

doitian commented Oct 23, 2019

Could you provide a schema and the buffer which could cause the panic?

@krojew
Copy link
Author

krojew commented Oct 23, 2019

Unfortunately, I can't provide the exact schema, but the following can show what happened:

  • create a schema with a verifier:
table A {
}

union U {
  A
}

table Container {
  a:A;
}
  • extend the schema:
table A {
}

table B {
}

union U {
  A,
  B
}

table Container {
  a:A;
}
  • process a buffer containing B wrapped in a Container - the verification will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants