This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
feat: add new UDT model which uses only one cell per wallet #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janx
reviewed
Dec 14, 2018
| token_info.name, | ||
| token_info.pubkey | ||
| Ckb::Utils.bin_to_hex(pubkey_bin) |
There was a problem hiding this comment.
Better refactor to use bin instead of hex in future, more space efficient.
There was a problem hiding this comment.
Agreed, we can use a future PR for this.
janx
reviewed
Dec 14, 2018
janx
reviewed
Dec 14, 2018
| ] | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
I feel it would be better to check the sum of two outputs equals the original cell[:amount], to prevent integer overflow on line #355 in case.
There was a problem hiding this comment.
I totally agree we should prevent integer overflow, but I believe we should do the check at here in the validator. The commented code here is the generator part which should be relatively safe.
Thoughts?
janx
approved these changes
Dec 14, 2018
| # * The matched output has the same amount of capacity but more tokens | ||
| # than the input | ||
| # This would allow a sender to send tokens to a receiver in one step | ||
| # without needing work from the receiver side. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our UDT model works on a set of cells in one account(like bitcoin model), this PR adds a new mode where we can use only one cell to represent a single account, which is like ETH model.
One novelty to this model is that it demonstrates how one can temporarily transfer his/her cell to a different user for valid manipulation.