Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the number type in RPC signatures to bigint #365

Closed
Keith-CY opened this issue Oct 11, 2019 · 1 comment
Closed

Update the number type in RPC signatures to bigint #365

Keith-CY opened this issue Oct 11, 2019 · 1 comment
Assignees
@Keith-CY
Labels
bug Something isn't working
Projects
RPC interface update

Comments

@Keith-CY
Copy link
Member

No description provided.

@Keith-CY Keith-CY added the bug Something isn't working label Oct 11, 2019
@Keith-CY Keith-CY self-assigned this Oct 11, 2019
@Keith-CY Keith-CY added this to TODO in RPC interface update via automation Oct 11, 2019
@Keith-CY
Copy link
Member Author

#363

Keith-CY added a commit that referenced this issue Oct 11, 2019
@Keith-CY
fix(rpc): update the signatures of rpc methods
36fa06d 
use bigint instead of number in signatures of rpc methods

BREAKING CHANGE: use bigint instead of number in signatures of rpc methods

re #363, fix #365
@Keith-CY Keith-CY mentioned this issue Oct 11, 2019
Closed
@Keith-CY Keith-CY moved this from TODO to WIP in RPC interface update Oct 11, 2019
@Keith-CY Keith-CY mentioned this issue Oct 12, 2019
Merged
RPC interface update automation moved this from WIP to Done Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keith-CY Keith-CY

Labels
bug Something isn't working
Projects
RPC interface update
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rpc): update the signatures of rpc methods ckb-js/ckb-sdk-js
1 participant
@Keith-CY