feat(core): parse scripts from addresses on generating transactions #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables parsing scripts from addresses on generating a transaction, instead of using the default secp256k1/blake160 script. But the lock script in change output is fixed to the default secp256k1/blake160 script. FWIW, the internal interface `generateRawTransaction` in core/generateRawTransaction is changed to accept scripts instead of public key hash.
Codecov Report
@@ Coverage Diff @@
## develop #488 +/- ##
===========================================
+ Coverage 95.40% 95.84% +0.44%
===========================================
Files 48 48
Lines 1522 1516 -6
Branches 292 292
===========================================
+ Hits 1452 1453 +1
+ Misses 70 63 -7
|
duanyytop
approved these changes
Sep 17, 2020
shaojunda
approved these changes
Sep 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables parsing scripts from addresses on generating a transaction, instead of using the
default secp256k1/blake160 script.
But the lock script in change output is fixed to the default secp256k1/blake160 script.
FWIW, the internal interface
generateRawTransactionin core/generateRawTransaction is changed to accept scripts instead of public key hash.