Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chroe: Upgrade deps #3778

Merged
merged 2 commits into from Jan 6, 2023
Merged

chroe: Upgrade deps #3778

merged 2 commits into from Jan 6, 2023

Conversation

driftluo
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #3708

upgrade clap and tentacle

Check List

Tests

  • Unit test
  • Integration test

Release note

None: Exclude this PR from the release note.

@driftluo driftluo requested a review from a team as a code owner December 30, 2022 10:01
@driftluo driftluo requested review from doitian and removed request for a team December 30, 2022 10:01
@driftluo driftluo force-pushed the upgrade-deps branch 3 times, most recently from 2ab5668 to 2c91338 Compare December 30, 2022 11:33
@driftluo
Copy link
Collaborator Author

driftluo commented Jan 6, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 6, 2023

Build succeeded:

@bors bors bot merged commit b57e813 into nervosnetwork:develop Jan 6, 2023
@driftluo driftluo deleted the upgrade-deps branch January 6, 2023 10:15
@quake quake mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to clap v4
2 participants
@driftluo @zhangsoledad