Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enrich WithdrawalWithStatus #706

Merged
merged 3 commits into from Jun 1, 2022
Merged

feat: enrich WithdrawalWithStatus #706

merged 3 commits into from Jun 1, 2022

Conversation

keroro520
Copy link
Contributor

No description provided.

@keroro520 keroro520 requested review from jjyr and zeroqn May 30, 2022 04:02
@gw-bot
Copy link

gw-bot bot commented May 30, 2022 •
edited

Running integration test

Workflow Run Id: 2406685437

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

jjyr
jjyr requested changes May 30, 2022
View reviewed changes
crates/jsonrpc-types/src/godwoken.rs Outdated Show resolved Hide resolved
@jjyr
Copy link
Collaborator

jjyr commented May 30, 2022 •
edited

  1. need to update doc/RPC.md
  2. please rebase develop branch to pass the CI

@gw-bot
Copy link

gw-bot bot commented May 31, 2022 •
edited

Running integration test

Workflow Run Id: 2412657055

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

jjyr
jjyr previously approved these changes Jun 1, 2022
View reviewed changes
@jjyr jjyr requested a review from blckngm June 1, 2022 03:24
@blckngm
Copy link
Contributor

blckngm commented Jun 1, 2022

RPC doc should be updated.

@keroro520 keroro520 force-pushed the gw-get-withdrawal-more-info branch from ba9e100 to 19f4ae1 Compare June 1, 2022 09:09
@gw-bot
Copy link

gw-bot bot commented Jun 1, 2022 •
edited

Running integration test

Workflow Run Id: 2420500208

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@keroro520
Copy link
Contributor Author

Sorry so long to reply.

Updated:

  • d76247e changes to the nested structure
  • 19f4ae1 updates the RPC document

@sopium @jjyr PTAL

@jjyr jjyr merged commit 06b823f into develop Jun 1, 2022
@jjyr jjyr deleted the gw-get-withdrawal-more-info branch June 1, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@zeroqn zeroqn zeroqn approved these changes

@jjyr jjyr jjyr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@keroro520 @jjyr @blckngm @zeroqn