Median time emitter #131
Merged
Median time emitter #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxuejie
reviewed
Dec 18, 2020
| let block_emitter = block_emitter.borrow(&guard); | ||
| let native_indexer = this.borrow_mut(&guard); | ||
| let mut block_emitters = native_indexer.block_emitters.write().unwrap(); | ||
| block_emitters.push(block_emitter.clone()); |
There was a problem hiding this comment.
I think we only need one block emitter, each median time emitter can subscribe from this single block emitter.
xxuejie
reviewed
Dec 18, 2020
packages/indexer/lib/index.js
Outdated
| add(key, value) { | ||
| const v = this.map.get(key); | ||
| if (v === undefined) { | ||
| this.map = this.map.set(key, { |
There was a problem hiding this comment.
All you need here is a plain Map, you can do:
const map = Map();
map[v] = map[v] || 0;
map[v] = map[v] + 1;
xxuejie
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.