Support anyone-can-pay script #69
Conversation
| public readonly fromScript: Script; | ||
|
|
||
| constructor( | ||
| fromAddress: Address, |
There was a problem hiding this comment.
Can we use FromInfo here?
| constructor( | ||
| fromAddress: Address, | ||
| cellProvider: CellProvider, | ||
| { |
There was a problem hiding this comment.
Can we skip QueryOptions here? Is there any chance that we have to let users customize the query used here?
There was a problem hiding this comment.
It's for anyone-can-pay with sudt https://github.com/nervosnetwork/lumos/pull/69/files#diff-2cf727f7322effda3e47a60c2bbcc253R199
If we skipped QueryOptions, we should provide a sudtToken param, for search anyone-can-pay lock script with sudt type script.
There was a problem hiding this comment.
Okay in that sense let's keep QueryOptions here.
| return txSkeleton; | ||
| } | ||
|
|
||
| export async function transfer( |
There was a problem hiding this comment.
I feel like maybe we should not provide transfer here. I do want to distinguish transfer from withdraw in lumos:
- transfer is an action that you exact CKBs from a bunch of cells that are alike, it does not matter which cell is in fact used.
- withdraw is an action that you exact CKBs from exactly one cell, and you can only use that single cell.
I feel like in ACP, it's more likely we are dealing with withdrawing operation, not transfer operation.
There was a problem hiding this comment.
It's this means we can withdraw a cell with withdraw capacity range [0,cell.capcaity-minimalCellCapcity] ∪ cell.capcaity, and withdraw amount (from data) range [0, cell.amount]
There was a problem hiding this comment.
Yeah I think that's the plan.
| return txSkeleton; | ||
| } | ||
|
|
||
| export async function destroyAnyoneCanPayInput( |
There was a problem hiding this comment.
One we change transfer to withdraw, I feel like we can merge this function with withdraw: the cell will be destroyed once one withdraw all the amount in the cell.
Now anyone-can-pay script only support to transfer anyone-can-pay addresses to anyone-can-pay address.
And transfer to anyone-can-pay address from any lock script will integrate to
commonlater.