Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use std::hint::spin_loop in cas loop #330

Closed
driftluo opened this issue Aug 18, 2021 · 1 comment · Fixed by #331
Closed

Should we use std::hint::spin_loop in cas loop #330

driftluo opened this issue Aug 18, 2021 · 1 comment · Fixed by #331

Comments

@driftluo
Copy link
Collaborator

driftluo commented Aug 18, 2021 •
edited by doitian
Loading

base：tokio-rs/tokio#4037 which resolves tokio-rs/tokio#4034

code：

tentacle/tentacle/src/channel/queue.rs

Lines 165 to 167 in 496e9e0

PopResult::Inconsistent => {
if inconsistent_spin_number == 0 {
thread::yield_now();

@doitian
Copy link
Member

doitian commented Aug 18, 2021

Do some benchmarks?

@driftluo driftluo mentioned this issue Aug 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: spin loop is better than thread yield nervosnetwork/tentacle
2 participants
@doitian @driftluo