Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow-cljs compiler #15

Open
arichiardi opened this issue Aug 30, 2017 · 4 comments
Open

Shadow-cljs compiler #15

arichiardi opened this issue Aug 30, 2017 · 4 comments

Comments

@arichiardi
Copy link
Contributor

Hi @moea!

Given that now serverless-cljs-plugin is very flexible regarding compilers, what about adding shadow-cljs?

There should be a very low amount of work to do there, because it already provides its on shadow-cljs.edn file for configuring things, we'd just need to trigger the command line command with the necessary parameters (:functions definitions I guess).

I myself like to work with the lumo for the speed of development and then compile production with something more solid (as you've seen, the lumo compiler is in its very early stages).

What do you think?

@moea
Copy link
Member

moea commented Aug 30, 2017

I'm fine with it if you think it can be implemented without many changes to the plugin.

@arichiardi
Copy link
Contributor Author

This has some quirk, and in particular the shadow-cljs compile command wants a parameter, the build-id.

@arichiardi
Copy link
Contributor Author

I think the idea here would be to reuse the stage variable from serverless

@arichiardi
Copy link
Contributor Author

arichiardi commented Sep 3, 2017

Uhm, I think I am try to fit square pegs in a round hole with this one, shadow-cljs controls the path of the generated artifact and there is no way to make it optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants