Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other] Upgrade to NextJS App router? #19

Closed
imminist opened this issue Jan 24, 2024 · 1 comment
Closed

[Other] Upgrade to NextJS App router? #19

imminist opened this issue Jan 24, 2024 · 1 comment
Labels
question Further information is requested

Comments

@imminist
Copy link

Dear nesaku,

I love your project. Do you have any plan to upgrade this project to App router?

@nesaku
Copy link
Owner

nesaku commented Jan 31, 2024

Hello imminist,

Glad you like BiblioReads and thank you for asking about this! This was something that I considered when Next.js 13 was released with support for the App router. At this point in time there are no plans to move to the App router. Here are some of the reasons why I first decided against using the App router which I still believe are valid:

  • The routing needs of BibilioReads are simple and do not require complex server side routing and/or rendering that would benefit from the App router
  • The Pages route is simpler than the App router, no need to complicate something that is stable
  • The Pages router file structure is more intuitive to work with compared to the App router(ex. multiple page.js files to keep track of)
  • The performance benefits that could come with using the App router are minimal compared to the required to fetch data
  • Moving to the App router would take some time and testing that could be better used building new features or supporting new/existing routes

I found that there were no meaningful benefits that would come with moving to the App router, but I'm always willing to reconsider if it will make BiblioReads better. Why do you think the App router should be used?

@nesaku nesaku added the question Further information is requested label Jan 31, 2024
@nesaku nesaku closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants