Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sfx(-1)" is required before playing same sound, duration parameter to sfx api. #87

Closed
AnastasiaDunbar opened this issue Apr 7, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@AnastasiaDunbar
Copy link

AnastasiaDunbar commented Apr 7, 2017

Even have to use sfx(-1) as an initializer.
Also using a value greater than 4 (or less than 0) for sfx channel then the application will crash.

@nesbox
Copy link
Owner

nesbox commented Apr 7, 2017

will fix and try to make sfx easier
thanks

@nesbox nesbox self-assigned this Apr 7, 2017
@nesbox nesbox added the bug label Apr 7, 2017
@trelemar trelemar changed the title In order to play the same sound effect again you have to use "sfx(-1)" before playing "sfx(-1)" is required before playing same sound, duration parameter to sfx api. Apr 10, 2017
@trelemar
Copy link
Collaborator

trelemar commented Apr 10, 2017

I'm gonna merge the other issue from here as they're very similar and relate:
#98

@nesbox
Copy link
Owner

nesbox commented Apr 23, 2017

you don't need to call sfx(-1) to stop playing sfx before start a new, it fixed since .22

  • but app still crashes if channel less than 0 or greater than 3
  • also I'm going to add duration parameter

@nesbox nesbox added this to the 0.23.0 milestone May 2, 2017
@nesbox
Copy link
Owner

nesbox commented May 3, 2017

added duration parameter
sfx id [ note [ duration [ channel [ volume [ speed ] ] ] ] ]
note - is absolute note = octave * 12 + note or string like "C#4"
duration - how many ticks to play sfx = -1 by default, to play sfx infinitely

done on .23

@nesbox nesbox closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants