-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create VariableSymbols for every differential order for variables? #299
Comments
@PTraeder Actually for an ODE system:
g_in is a state variable, g_in' is added due to the first equation. Which symbols would you like to create additionally? |
I think I am just generally confused with the ODE syntax. Do we have the guarantee that the rhs of ODEs will only ever include derivations of order n-1 (where the order of the lhs would be n)? |
Actually, I just stumbled upon this issue, which I think is related to a problem I saw regarding magnitudes: derivatives are not computed in the "coherent" magnitudes for NEST (e.g. I do not understand what bothers @PTraeder but I think maybe the problem partly comes from the choice in the "default" magnitudes:
Therefore, I think it would be a good idea that:
|
This really just related to implementation details and the concept behind @DimitriPlotnikov implementation of the ODE system's internals and the issue could be considered closed. With regards to @Silmathoron suggestions: changing the standard "s" to a "ms" is probably perfectly reasonable, as this relates more to simulation resolution (I assume). |
I'm not talking about time: you would need to change all default magnitudes to match the "neuroscience system", which, I think, is:
As you can see, time is usually in seconds: here, the problem comes from NEST... (I was a bit too quick in asserting the coherence of the NEST system) The way I see it, it would be better to be coherent and implement the "neuroscience system" as is... but this would mean converting the time constants. I would still recommend talking about this in more details with the community, though, as it is not a completely trivial matter. |
@Silmathoron
|
Hi @DimitriPlotnikov! My idea was that the system should be coherent, based on the main NEST units (mV, pF, nS, ms) Therefore the resistance should be such that But this was just the way I thought we should try to use, so I'd like to have @jougs and @heplesser opinions on that matter, since I think it is more a matter of how handy and natural the units are... |
@Silmathoron indeed. that is what we are working on. |
Since the LHS of an ODE can be typed "dynamically" to some extend ( magnitude information can be modified depending on the defining ODE) it might be sensible to create symbols for each and every occurring differential order of a given variable, not just all but the highest one.
This would help me shut up the warnings from issue#291 in cases where a suitable type can be inferred.
Otherwise a switch for typechecks that ignores magnitude is the only option.
@DimitriPlotnikov What do you think?
The text was updated successfully, but these errors were encountered: