Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using fixed width integer types #90

Closed
riffard opened this issue Feb 22, 2021 · 2 comments
Closed

Using fixed width integer types #90

riffard opened this issue Feb 22, 2021 · 2 comments

Comments

@riffard
Copy link
Collaborator

riffard commented Feb 22, 2021

Modern C++ requires to use of the fixed-width integer types that were introduced in C++11. It's recommended to use int64_t instead of long int. The header is cstdint: documentation.

@tunnell
Copy link
Member

tunnell commented Feb 23, 2021

These are good suggestions. If it's quick, you have a better feeling for C++11 than we do, so you're welcome to try your hand at a PR that we can test to make sure things function fine. Right now NEST is maintaining more than developing, so this will happen but probably slowly.

@mszydagis
Copy link
Collaborator

I have fixed this today, didn't take long thanks to grep, Quentin and Chris -- Will be uploading later tonight, combining with the other minor issues. I even went one step further and changed all unsigned long or unsigned long int's to uint64_t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants