Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP 2 - Major refactors #45

Closed
5 tasks
zorbyte opened this issue Jun 7, 2020 · 8 comments
Closed
5 tasks

MVP 2 - Major refactors #45

zorbyte opened this issue Jun 7, 2020 · 8 comments
Assignees
Milestone

Comments

@zorbyte
Copy link
Contributor

zorbyte commented Jun 7, 2020

MVP 2's design focus will be for the standardisation of technologies, modularity and service segregation.

Key Concepts and/or Goals:

  • Package CDN:
    • Support Vanilla JS with TypeScript Definitions through the X-TypeScript-Types
      header
  • API:
    • Dockerise this, setup automatic deployments to server through GitHub actions
    • Allow custom READMEs. This applies to both a custom name and location
  • Common Module:
    • Types, such as request payloads and DB data shapes. common/types
    • The import follower. common/follower
    • API library for web and possibly server side if required. common/api
  • Style Guide
    • Enforce branch naming system:
      • Create a regex for GitHub branch naming rules
      • For long term features, quick fixes or bug fixes use the following format:
        • Use feature branches named as: feature/<feature_name>
        • Use bug fix branches named as fix/<fix_name>
      • Use master for production deployments
      • Use a trunk branch, probably named in-dev
    • Enforce commit naming guidelines. See conventional commits
    • Enforce a file naming scheme
    • Create an eslint configuration
    • Use a common prettier config that is compatible with deno fmt
    • Follow the Deno style guide where applicable
  • Website:
    • Allow users to browse the file tree of a module
    • Allow users to view a user profile along with all their packages
    • Relative files in READMEs should be fixed
    • Gallery should display the eggs CLI first, followed by packages ordered by using
      the popularity of it multiplied by a randomness factor which becomes larger the
      less popular the packages are to allow them to compete (hopefully to be mixed
      with big packages and just below them). The favouritism feature for small
      packages should only be enabled when its versions and usages/requests of each
      version breaks a relatively small but reasonable threshold. This would avoid
      random "nonsense" packages from appearing at the top as well as provide incentive
      for package developers to market their packages
    • Rewrite website in TypeScript
    • Use the API library from the common modules
@zorbyte zorbyte added this to the 0.2.0 milestone Jun 7, 2020
@zorbyte zorbyte assigned t8 and zorbyte Jun 7, 2020
@zorbyte zorbyte pinned this issue Jun 7, 2020
@t8
Copy link
Member

t8 commented Jun 9, 2020

I would suggest not rewriting the website in TypeScript for now, until Deno gets better web modules added and becomes more reliable.

@zorbyte
Copy link
Contributor Author

zorbyte commented Jun 9, 2020

TypeScript != Deno

@t8
Copy link
Member

t8 commented Jun 9, 2020

My apologies. You're correct. I just assumed you meant Deno.

@fakoua
Copy link

fakoua commented Jun 16, 2020

I would suggest adding Category for a package (categories and keywords)

@t8
Copy link
Member

t8 commented Jun 16, 2020

@fakoua this is an interesting idea. What would some examples of categories be?

@fakoua
Copy link

fakoua commented Jun 16, 2020

@tbaumer22 categories could be: Web Framework, Command lines, utilities, string manipulation, User Interface, Images, Console, ...
And keywords comma separated.

@t8
Copy link
Member

t8 commented Jun 20, 2020

@fakoua we'll look into adding this feature sometime in the future. It should definitely help with navigation through the packages!

@SteelAlloy SteelAlloy unpinned this issue Jul 9, 2020
@SteelAlloy SteelAlloy pinned this issue Jul 9, 2020
@zorbyte
Copy link
Contributor Author

zorbyte commented Jul 11, 2020

Closing due to major changes that conflict with this issue.

@zorbyte zorbyte closed this as completed Jul 11, 2020
@zorbyte zorbyte unpinned this issue Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants