Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Installation URL not accurate for any file other than mod.ts #67

Closed
t8 opened this issue Jun 14, 2020 · 6 comments · Fixed by #184
Closed

[BUG] Installation URL not accurate for any file other than mod.ts #67

t8 opened this issue Jun 14, 2020 · 6 comments · Fixed by #184
Assignees

Comments

@t8
Copy link
Member

t8 commented Jun 14, 2020

Describe the bug
If a user were to use an "index" file other than mod.ts, the registry would not update this information.

To Reproduce
Publish a package to the registry that does not use mod.ts as the main script in the project root.

Expected behavior
The index file should be passed through the API to allow the frontend to fetch and set it dynamically.

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS
  • nest.land Version: 0.1.0

Additional context
Blob is assigned to this as well because it involves the API.

@t8 t8 added the bug label Jun 14, 2020
@t8 t8 assigned t8 and justablob Jun 14, 2020
@t8 t8 added the invalid label Jun 14, 2020
@justablob
Copy link
Contributor

I'd say we should make a mod.ts file mandatory, as it seems to already be a standard in the Deno community.

@zorbyte
Copy link
Contributor

zorbyte commented Jun 15, 2020

It's a de facto standard. We shouldn't.

@littledivy
Copy link
Member

It's not an official standard though, this should be considered as it might drive away people who have their project working with another index file, they would not want to change it.

@zorbyte
Copy link
Contributor

zorbyte commented Jun 16, 2020

Why is this marked as invalid? This issue should definitely be addressed.

@zorbyte zorbyte removed the invalid label Jun 16, 2020
@t8
Copy link
Member Author

t8 commented Jun 16, 2020

My apologies. I marked this issue as invalid because the website was showing invalid information. I must have misunderstood the meaning of this tag.

@t8
Copy link
Member Author

t8 commented Jun 18, 2020

We've implemented an "entry" file for 0.1.3, but this is not added in the frontend yet. This addition will be coming soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants