Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest v8 Support - Update of axios dependency to at least v1.2.2 #677

Closed
2 of 4 tasks
NicoAiko opened this issue Feb 10, 2023 · 1 comment
Closed
2 of 4 tasks

Nest v8 Support - Update of axios dependency to at least v1.2.2 #677

NicoAiko opened this issue Feb 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@NicoAiko
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Like explained in axios/axios#5346 and also in #641 there is a problem with v1.2.1 of the axios package. Unfortunately there hasn't been a version bump that's usable for projects that still use Nest v8.
We can't currently upgrade to Nest v9, so it would be fantastic, if there was a bump in the dependency version.

Minimum reproduction code

Steps to reproduce

No response

Expected behavior

Should be able to use the httpService without the above mentioned bug.

Package version

1.0.1

NestJS version

8.4.7

Node.js version

16.16.0

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@NicoAiko NicoAiko added the bug Something isn't working label Feb 10, 2023
@kamilmysliwiec
Copy link
Member

Not sure if I'm following. You just need to upgrade the underlying axios package without upgrading Nest - is that correct? If so, check out this link https://stackoverflow.com/questions/52416312/npm-equivalent-of-yarn-resolutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants